Change way of working on DlqDeserializationExceptionHandler. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clvacher
requested changes
Aug 24, 2023
| return DeserializationHandlerResponse.CONTINUE; | ||
| // here we only have exception like UnknownHostException for example or TimeoutException ... | ||
| // example: we cannot ask schema registry De | ||
| return DeserializationHandlerResponse.FAIL; |
There was a problem hiding this comment.
Coudl the whole method be optimized for readability, i.e with a finally statement?
| @@ -52,7 +59,9 @@ public DeserializationHandlerResponse handle(ProcessorContext processorContext, | |||
| return DeserializationHandlerResponse.FAIL; | |||
| } | |||
|
|
|||
| return DeserializationHandlerResponse.CONTINUE; | |||
| // here we only have exception like UnknownHostException for example or TimeoutException ... | |||
| // example: we cannot ask schema registry De | |||
…on pill ☠ and CONTINUE and FAIL only if we had network issue (schema registry timeout for example) 💻
clvacher
force-pushed
the
feat/add_retries_for_DlqDeserializationExceptionHandler.java
branch
from
d19248c to
a4aefde
Compare
|
Kudos, SonarCloud Quality Gate passed! |
clvacher
approved these changes
Sep 6, 2023
loicgreffier
changed the title
loicgreffier
deleted the
feat/add_retries_for_DlqDeserializationExceptionHandler.java
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change DlqDeserializationExceptionHandler.
1- catch poison pill ☠ - sent a message in DLQ and CONTINUE (if we had trouble to produce in dlq : FAIL)
2- FAIL only if we have a network issue (schema registry timeout for example)